xwem-devel
[Top] [All Lists]

[AC] [PACKAGES (xwem)] Fix minor bug in bug-reporter

From: Steve Youngs <steve@xxxxxxxx>
Subject: [AC] [PACKAGES (xwem)] Fix minor bug in bug-reporter
Date: Sun, 05 Dec 2004 16:57:18 +1000
Cc: XEmacs Patches <xemacs-patches@xxxxxxxxxx>
Organization: The XWEM Project
User-agent: Gnus/5.110003 (No Gnus v0.3) XEmacs/21.4 (Security Through Obscurity, linux)
APPROVE COMMIT

What's a bug reporter without bugs?

NOTE: This patch has been committed.


xwem patch:
ChangeLog files diff command: cvs -q diff -U 0
Files affected:               ChangeLog
Source files diff command:    cvs -q diff -uN
Files affected:               lisp/xwem-report.el

Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/xwem/ChangeLog,v
retrieving revision 1.64
diff -u -U0 -r1.64 ChangeLog
--- ChangeLog   5 Dec 2004 05:52:22 -0000       1.64
+++ ChangeLog   5 Dec 2004 06:55:33 -0000
@@ -2,0 +3,7 @@
+       * lisp/xwem-report.el: Autoload xwem-dpy, X-Dpy at compile time.
+       (xwem-report-debug): Don't include
+       xwem-loaddefs.el in the files to snoop for changed variables.
+       (xwem-prepare-report): Include xwem and xlib version strings.
+
+2004-12-05  Steve Youngs  <steve@xxxxxxxxxxxxx>
+
Index: lisp/xwem-report.el
===================================================================
RCS file: 
/pack/xemacscvs/XEmacs/packages/xemacs-packages/xwem/lisp/xwem-report.el,v
retrieving revision 1.1
diff -u -u -r1.1 xwem-report.el
--- lisp/xwem-report.el 5 Dec 2004 05:52:30 -0000       1.1
+++ lisp/xwem-report.el 5 Dec 2004 06:55:23 -0000
@@ -95,15 +95,14 @@
                 "xwem-osd.el" "xwem-tabbing.el" "xwem-selections.el"
                 "xwem-root.el" "xwem-report.el" "xwem-desktop.el" 
                 "xwem-faces.el" "xwem-tray.el" "xwem-main.el" "xwem-sound.el"
-                "xwem-loaddefs.el" "xwem-strokes.el" "xwem-edmacro.el"
-                "xwem-clgen.el" "xwem-launcher.el" "xwem-frame.el"
-                "xwem-special.el" "xwem-interactive.el" "xwem-transient.el"
-                "xwem-keyboard.el" "xwem-mouse.el" "xwem-misc.el"
-                "xwem-focus.el" "xwem-keymacro.el" "xwem-rooter.el"
-                "xwem-rooticon.el" "xwem-clients.el" "xwem-minibuffer.el"
-                "xwem-register.el" "xwem-clswi.el" "xwem-icons.el"
-                "xwem-manage.el" "xwem-netwm.el" "xwem-win.el"
-                "xwem-theme.el"))
+                "xwem-strokes.el" "xwem-edmacro.el" "xwem-clgen.el"
+                "xwem-launcher.el" "xwem-frame.el" "xwem-special.el"
+                "xwem-interactive.el" "xwem-transient.el" "xwem-keyboard.el"
+                "xwem-mouse.el" "xwem-misc.el" "xwem-focus.el"
+                "xwem-keymacro.el" "xwem-rooter.el" "xwem-rooticon.el"
+                "xwem-clients.el" "xwem-minibuffer.el" "xwem-register.el"
+                "xwem-clswi.el" "xwem-icons.el" "xwem-manage.el"
+                "xwem-netwm.el" "xwem-win.el" "xwem-theme.el"))
        (print-level 5)
        (point (point))
        file expr olist sym)
@@ -167,6 +166,11 @@
               (nth 4 (car pkgs))))
       (setq pkgs (cdr pkgs)))))
 
+(eval-when-compile
+  (autoload 'xwem-dpy "xwem-struct" nil nil 'macro)
+  (require 'xlib-xc)
+  (defvar xlib-version))
+
 (defun xwem-prepare-report ()
   "Grabs the variables, features to include in bug report.
 Then put it all into a mail buffer, nicely formatted."
@@ -182,7 +186,8 @@
    "System info to help the XWEM boys and girls try to fix your bug:\n"
    "==============================================================="
    "\n\n")
-  ;; Insert a version string here
+  (insert (format "%s" xwem-version) "\n"
+         (format "%s" xlib-version) "\n\n")
   ;; xdpyinfo
   (insert "Output from xdpyinfo:\n--------------------\n\n"
          (shell-command-to-string (concat "xdpyinfo -display "
@@ -265,7 +270,7 @@
   (if xwem-report-bug-send-init
       (if (file-readable-p user-init-file)
          (save-excursion
-           (message-goto-signature)
+           (goto-char (point-max))
            (forward-line -3)
            (beginning-of-line)
            (insert "\n\nUser Init File:\n--------------\n\n")

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|                        In space,                         |
|             No one can hear you rip a stinky             |
|---------------------------------------<steve@xxxxxxxx>---|

Attachment: pgpscK3ZesSUS.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>
  • [AC] [PACKAGES (xwem)] Fix minor bug in bug-reporter, Steve Youngs <=